Andrey Turkin wrote:

Taken from Etersoft git tree with some small fixes (code style, constness etc) and minimal /C mode support required to fix bug 18097.
---
 configure.ac                  |    1 +
 programs/extrac32/Makefile.in |   16 ++
programs/extrac32/extrac32.c | 423 +++++++++++++++++++++++++++++++++++++++++
 programs/extrac32/parsecmd.c  |  100 ++++++++++
 4 files changed, 540 insertions(+), 0 deletions(-)
 create mode 100644 programs/extrac32/Makefile.in
 create mode 100644 programs/extrac32/extrac32.c
 create mode 100644 programs/extrac32/parsecmd.c
Hi, Andrey.

The first spotted:

---
+int PASCAL wWinMain ( HINSTANCE hInstance, HINSTANCE prev, LPWSTR cmdline, int show )

+{
...
+    UINT    j = 0;
---

This initializer looks redundant

---
+LPWSTR* ParseCmdline( LPCWSTR cmdline, int *argc )

+    BOOL    bQuote = FALSE;

...
+    i = j = k = z = nQuotes = 0;
---

This is redundant for i and nQuotes at least.




Reply via email to