Kai Blin wrote: > On Saturday 10 October 2009 22:52:48 Vitaliy Margolen wrote: > >>> Changelog: >>> ws2_32: Use the routing table information for >>> gethostbyname('self') if the magic IP would otherwise be returned. >> Thanks for the patch, however there are few issues with it. >> >> Why do you return a list of IP addresses from WS2_get_local_ips if you need >> only one? Just get the one with the lowest metric and return it. >> >> I think it would be better > > That's not what Windows does, though. Windows returns the full list. > Got you, then what the patch does is still can be improved.
Since patch using WS2_get_local_ips() in one place only return something you can just pass directly to the app, not something that needs duplicating and then freeing. Vitaliy.