2010/1/6 Maarten Lankhorst <m.b.lankho...@gmail.com>: > Hi Reece, > > Reece Dunn schreef: >> >> NOTE: Some of the DllCanUnloadNow functions always return S_OK. I >> intend to address that in a separate patch once I have investigated >> whether the DLLs implement COM objects or not. >> > > When a dll is first implemented it probably returns S_OK since no interfaces > were used yet, but some programs just depended on the dll being present. > However the FIXME should not be removed then, since if it does implement > interfaces and it gets freed while in use this can be a serious crash. I'd > rather have that message then as a red flag for investigation. Returning > nothing in case of S_FALSE is fine though, but a TRACE() would still be nice > there just in case.
Ok. I'll keep the FIXMEs for the ones that return S_OK and convert the others to TRACE. Thanks, - Reece