Re: [spam-high] RE: Significant performance "regression"

[Erich Hoover]

On Fri, Feb 26, 2010 at 11:31 AM, Erich Hoover <ehoo...@mines.edu> wrote:

> I was looking into updating the AppDB with more recent results for PCB
> Artist* and discovered that on a fresh Wine install that the application
> opens and creates new files incredibly slowly (it now takes 23 minutes vs.
> old performance of ~5 seconds).
>
...
>

I've done a little bit of looking into this performance problem and I have
discovered a fix (patch attached).  Since I'm not familiar with the code
here I would appreciate it if you would look it over and determine whether
it is appropriate or it just covers over some other problem.

Erich Hoover
ehoo...@mines.edu

diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c
index 837365b..371ae9c 100644
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -3991,6 +3991,7 @@ static HRESULT CreateSnapshotFile(StorageBaseImpl* original, StorageBaseImpl **s
       snapshotData.clsid = parentData.clsid;
       snapshotData.ctime = parentData.ctime;
       snapshotData.mtime = parentData.mtime;
+      snapshotData.dirRootEntry = parentData.dirRootEntry;
       hr = StorageBaseImpl_WriteDirEntry((*snapshot),
         (*snapshot)->storageDirEntry, &snapshotData);
     }