David Hedberg <david.hedb...@gmail.com> writes:

> +    /* Native accepts a NULL prc, so should we. */
> +    if(prc)
> +        SetWindowPos(This->hwnd_main, HWND_TOP, prc->left, prc->top,
> +                     prc->right - prc->left, prc->bottom - prc->top, 
> SWP_SHOWWINDOW);

It would be better to create it directly with the correct rectangle.
Also SWP_SHOWWINDOW is not useful since the window is created
visible. And please don't add comments like "native does this", that
should be true of pretty much anything we do. Native behavior should be
documented by test cases anyway, not comments.

-- 
Alexandre Julliard
julli...@winehq.org


Reply via email to