Some compilers complain about the lack of a return in a void function. Don't forget to add it in each void function.
A+ David ________________________________ De : Austin Lund <austin.l...@gmail.com> À : Vitaliy Margolen <wine-de...@kievinfo.com> Cc : wine-devel@winehq.org Envoyé le : Jeu 12 août 2010, 8h 09min 44s Objet : Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. On 12 August 2010 15:48, Vitaliy Margolen <wine-de...@kievinfo.com> wrote: > You can't test that. All you can test is that you got the IDirectMusicPort > back or not. What exactly inside is irrelevant. > > And if IDirectMusicPerformance8_PChannelInfo succeeds and you getting not > null pDirectMusicPort back but it points to bogus data or is unchanged (as > it is now), it's outright invalid behavior that should be fixed. No tests > needed for that. OK. How about this: static void test_PChannelInfo(void) { IDirectMusicPort *pDirectMusicPort; HRESULT hr; pDirectMusicPort = NULL; hr = IDirectMusicPerformance8_PChannelInfo(idmusicperformance, 0, &pDirectMusicPort, NULL, NULL); ok(hr == S_OK, "Failed to call PChannelInfo (%x)\n", hr); todo_wine ok(pDirectMusicPort != NULL, "IDirectMusicPort not set\n"); } I'll take on other comments and resubmit tomorrow as suggested. Thanks.