On 07/08/2011 02:06 AM, Ricardo Filipe wrote: > 2011/7/8 Christian Inci <chris.pcguy.i...@gmail.com > <mailto:chris.pcguy.i...@gmail.com>> > > On 07/08/2011 01:22 AM, Juan Lang wrote: > > Hi Christian, > > this isn't quite what Alexandre meant. *What* did you fix? Saying > > you did so isn't enough. > > Thanks, > > --Juan > I'm sorry, I thought you can see it out of the sourcecode. > > PATCH 1: Don't load any variables which aren't in a section. > PATCH 2: Don't increase seclen or keylen by 1(one) if section name, key > name is empty. (a empty name seems to be valid too.) > PATCH 3: Don't return default value if keyname is empty. If keyname is > NULL return error (ERROR_FILE_NOT_FOUND). Allow empty section name. > PATCH 4: GetPrivateProfileStringA should set two null bytes. > PATCH 5: If filename is NULL return error (ERROR_FILE_NOT_FOUND). > PATCH 6: GetPrivateProfileSectionNamesA should set two null bytes. (try > 5 of PATCH 6 coming soon.) > > > that's what you should write in the patch subjects :) > dll : fix description
Thank you all for the hints. :) I'll remember it for the next patches.