On 07/26/11 13:04, Henri Verbeet wrote: > On 26 July 2011 10:57, Jacek Caban <ja...@codeweavers.com> wrote: >> It's better to test for the exact value in tests like hr == S_OK. It >> makes tests stricter. > I don't think that making tests more strict than necessary is a good > principle.
If there is no cost of having tests more strict (like code complication), it is a good principle IMO. In this case it's a matter of choosing the right way for testing results, so it should be preferable. > (Not that it matters a lot here anyway, for most of these > D3D_OK is the only possible sucessful return value.) How can you be sure without tests? Cheers, Jacek