On 3/21/2012 09:24, Eric Culp wrote:
On Wed, Mar 21, 2012 at 2:59 AM, Nikolay Sivov <bungleh...@gmail.com
<mailto:bungleh...@gmail.com>> wrote:
On 3/21/2012 08:58, Eric Culp wrote:
The two functions have different return values on windows for
analogous inputs.
Changed to match windows behavior.
---
dlls/shlwapi/url.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
Please add some tests for that.
I think it's already covered by
dlls/shlwapi/tests/url.c:672
res = pUrlGetPartA("hi", szPart, &dwSize, URL_PART_SCHEME, 0);
ok (res==S_FALSE, "UrlGetPartA(\"hi\") returned %08X\n", res);
and
dlls/shlwapi/tests/url.c:685
res = pUrlGetPartW(hiW, bufW, &dwSize, URL_PART_SCHEME, 0);
todo_wine ok(res==S_OK, "UrlGetPartW(\"hi\") returned %08X\n", res);
Line 686 was the one that previously triggered a todo. Should the
todo_wine be removed?
Yes, you should run 'make test' and get no errors after your changes. If
you fixed todo it should be removed, if you break existing test you
should fix your patch.
