Monday 17 December 2012 Dmitry Timoshkov <dmi...@baikal.ru> > Stefan Leichter <stefan.leich...@camline.com> wrote: > > + BYTE buffer[MAX_PATH]; > > This should be WCHAR if you decided to test unicode version of the API > (although testing ANSI variant would be much easier), that will help > to avoid all those casts, and protect from insufficient buffer size. > Also please use a font that exists in Wine, such as sserife.fon, but > be prepared that it could be not found since font file name is locale > dependent.
First of all: The issues your are pointing out have been in the previous version of the patch too. Why didn't you complain in your first review. To my understanding this is a wast of my time complaining about two issues and keeping the rest secret for the next version of the patch. Now to the technical stuff: - i agree to change the data type to WCHAR - what you mean with "protect from insufficient buffer size" it totaly unclear to me - the tests are written for a font in %windor%\fonts. This directory is empty after a clean .wine directory was created. Changing the font does not help at all. -- Stefan
