Re: kernel32/tests : try2 added tests for copyfileex

[siro]

OK, but how do I know that the old behavior is broken ? WindowsXp behaves like msdn quotes while newer windows don't. Do you always assume that the latest implementation is correct ? Should wine just match the latest test-results and ignore osversioninfo at all ?

---

Von: "Dmitry Timoshkov" <dmi...@baikal.ru>
An: "Patrick Rudolph" <s...@das-labor.org>
Cc: "wine-devel@winehq.org" <wine-devel@winehq.org>
Gesendet: 11. Januar 2013 04:06
Betreff: Re: kernel32/tests : try2 added tests for copyfileex

Patrick Rudolph  wrote:

> try2:
> check the os version in case of PROGRESS_STOP

> +    ret = GetFileAttributesEx(dest_name, GetFileExInfoStandard, (void*)&fileInfo);
> +
> +    /* Windows Vista and newer delete the file, while prior versions don't */
> +    ok((!ret && info.dwMajorVersion > 5) || (ret && info.dwMajorVersion <= 5),
> +        "GetFileAttributesEx return-value wrong, got %u and MajorVersion is %u\n", ret, info.dwMajorVersion);

Then you should mark old behaviour as broken() and don't check Windows
version at all.

-- 
Dmitry.