Thanks for looking at it.

I'll do a mass move of the .cvsignore files later. Jactry should just leave it out if his final patch.

We prefer UTF-8 as that is what the underlying template engine of the website understands. Modern browsers should be able to use it just fine (hopefully, even in China).

-N

On Wed 30 Jan 2013 10:45:28 AM CST, Hin-Tak Leung wrote:
--- On Wed, 30/1/13, Jeremy Newman <jnew...@codeweavers.com> wrote:

Patch looks good to me. Since I
cannot read it, I need someone else here on wine devel to
vouch for the translation. Just to make sure it is legit and
not a very tricky spam or just a pass through google
translate.

You will also need to add a string to the
$this->languages array in the data class
(include/data.php)

I also noticed we are still using .cvsignore files, oops.
Those should get moved to .gitignore, but I can do that
later.

The translation of the content is largely okay. I also find it a bit strange 
with the .cvsignore file, and also the google_analytic.template file - I think 
that probably should be factored out into a language-neutral template.

Just a note that the encoding is zh_CN.utf8, rather than the 
more-common-in-China zh_CN.GB18030 .

(I think you can find me as a distant-past code contributor - got a couple of 
patches in, in the mshtml area, I think, a long time ago - and active on 
bugzilla for some years).




Reply via email to