2013/4/10 Henri Verbeet <hverb...@gmail.com>: > On 10 April 2013 01:35, Matteo Bruni <mbr...@codeweavers.com> wrote: >> --- >> dlls/wined3d/utils.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c >> index da8fc7b..5010676 100644 >> --- a/dlls/wined3d/utils.c >> +++ b/dlls/wined3d/utils.c >> @@ -1038,6 +1038,9 @@ static void check_fbo_compat(const struct >> wined3d_gl_info *gl_info, struct wined >> GLenum status; >> GLuint tex; >> >> + if (!(format->flags & WINED3DFMT_FLAG_TEXTURE)) >> + return; >> + > > I'm not sure about this one, what exactly should this achieve? In > either case, this probably belongs in init_format_fbo_compat_info(), > together with the other similar checks. >
The idea is that, since check_fbo_compat() creates a texture of the specified format to attach it to a test FBO and verify that it works correctly, it doesn't make sense to even try if the format is non-texturable. The check can surely go to init_format_fbo_compat_info() instead.