On 04/26/13 16:18, Alexandre Julliard wrote: > Jacek Caban <ja...@codeweavers.com> writes: > >> On 04/26/13 14:46, Alexandre Julliard wrote: >>> Jacek Caban <ja...@codeweavers.com> writes: >>> >>>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. >>>> Previous versions had a separated library that contained forwards from >>>> underscored functions to non-underscored, which I believe made using >>>> hypot work. Those were currently moved directly to msvcr* import libs, >>>> which we don't use in favour of our our own ones. >>> Don't you need to do that for the other functions too? >> With just this patch, the compilation works fine for me. There were not >> that many functions affected by mingw-w64 change. Note that most msvcrt >> functions are exported without underscore prefix. AFAICS, MSVC has such >> inline wrapper in math.h only for hypot and hypotf. I checked why hypodf >> was not affected so far and it seems like it's just because it uses >> different way of forwarding in mingw-w64 crt, so that's also worth >> changing in our math.h to be safe for the future changes. > It looks to me like j0/j1/jn etc. would need it too.
We don't use them outside msvcrt, AFAICS. But yeah, we could have it for sake of completeness. Jacek