Out of curiosity. Not freeing these memory allocations shouldn't disturb Valgrind to report false memory leaks?
2013/5/21 Alexandre Julliard <julli...@winehq.org> > Dmitry Timoshkov <dmi...@baikal.ru> writes: > > > Alexandre Julliard <julli...@winehq.org> wrote: > > > >> >> case DLL_PROCESS_DETACH: > >> >> - msvcrt_free_popen_data(); > >> >> msvcrt_free_io(); > >> >> + if (lpvReserved) break; > >> >> + msvcrt_free_popen_data(); > >> >> msvcrt_free_mt_locks(); > >> >> msvcrt_free_console(); > >> >> msvcrt_free_args(); > >> > > >> > Shouldn't msvcrt_free_io() be also protected by this guard? > >> > >> I think we still want to try to flush the file buffers. > > > > My point was that msvcrt_free_io() does much more than just flushing > > file buffers, it also frees memory and deletes critical sections. > > It should probably call fflush or flushall instead, but that doesn't > flush stdio. I'm not quite convinced that this is correct, it would need > test cases. > > -- > Alexandre Julliard > julli...@winehq.org > > >
