2013/5/31 Detlef Riekenberg <wine....@web.de> > Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > > > + */ > > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD > *pvalue) > > > +{ > > > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR > lpszValueName, LPDWORD pdwValue); > > > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > > > I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :) > > I disagree for "const WCHAR *", which is really rare used in Wine > (Please grep the headers yourself) > > There was a discussion about the LPxxx stuff removal (I guess Pxxx as well) some time ago. There was also something about const that doesn't behave as expected in that case but I don't remember the details.
> pvalue is a matter of taste. > It's not particularily my taste. It's something preferred. It was just a guess since the patch was pending. Christian