On 2013-06-26 22:49, André Hentschel wrote: > On 26.06.2013 22:06, Thomas Faber wrote: >> On 2013-06-26 21:47, André Hentschel wrote: >>> The whitespace changes are bad, please don't do that. >> >> Ok, I can take them out no problem. >> Why's it bad though? I thought the rule was "fix it while you're >> working on it anyway". >> > > Mostly because you mess up "git blame" output. > See also http://wiki.winehq.org/SubmittingPatches
On 2013-06-26 23:04, Michael Stefaniuc wrote: > Sure, fix the lines you modify and the block you're in. > Avoid having whitespace only diff chunks. Makes sense, thanks. Fixed.