On Thursday, 1 August 2013 11:55 PM, Nikolay Sivov wrote:
>> +    p = strchrW(key_name,'\\');
>> +    if (!p)
>> +    {
>> +        p = 0;
>> +    }
>> +    else p++;
>I'm not sure what this is supposed to do.

It is equivalent to the following code;

    p = strchrW(key_name, '\\');
    if (p != NULL) p++;

I've now modified the patch to represent this.

>> +        case REG_BINARY:
>> +        case REG_NONE:
>> +            pValue = value;
>> +            for (i=0; i<valueSize; i++, pValue++)
>> +                reg_printfW(formatXW, *pValue);
>> +            break;
>There's no need for separate variable here nor for incrementing pointer.

The incrementing pointer is needed because the 'value' is a Byte array. But the 
separate variable is not needed.


Reply via email to