On Sep 3, 2013, at 12:37 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard <julli...@winehq.org> > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >>>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard <julli...@winehq.org> >>>> wrote: >>>>> Bruno Jesus <00cp...@gmail.com> writes: >>>>> >>>>>> try 2: >>>>>> Narrow the loop for the specified protocol >>>>>> Add a new test for invalid sockets >>>>> >>>>> Considering what WSAEnumProtocols does, the loop doesn't seem necessary >>>>> at all. >>>> >>>> It will when WSAEnumProtocols return AF_INET6 data =) >>> >>> Will you find more reasonable to "unstatic" >>> WINSOCK_EnterSingleProtocolW from protocol.c, add a family parameter >>> to it and use it inside socket.c ? >> >> Yes, though moving it all to socket.c is probably cleaner. We don't need >> a separate file for just that one API. > > You mean removing protocol.c and adding all content to socket.c? If > yes I would appreciate if you could do that because I don't have the > git skills and wouldn't now how to sort the functions inside socket.c. It's not that hard. Just copy all the substantial stuff from protocol.c into socket.c, and then you can run:
$ git rm --force protocol.c $ git commit --amend socket.c protocol.c # apply changes to your existing commit Chip
