Hi Akira,

On 09/23/13 10:00, Akira Nakagawa wrote:
> From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001
> Message-Id: 
> <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapir...@gmail.com>
> From: Akira Nakagawa <matyapir...@gmail.com>
> Date: Mon, 23 Sep 2013 17:00:04 +0900
> Subject: [PATCH] add ual directory (try9)
>
> ---
>  configure                       |  2 +
>  configure.ac                    |  2 +
>  dlls/ualapi/Makefile.in         |  6 +++
>  dlls/ualapi/main.c              | 86 
> +++++++++++++++++++++++++++++++++++++++++
>  dlls/ualapi/tests/Makefile.in   |  8 ++++
>  dlls/ualapi/tests/ualapi_test.c | 38 ++++++++++++++++++
>  dlls/ualapi/ualapi.spec         |  4 ++
>  include/Makefile.in             |  1 +
>  include/ual.h                   | 48 +++++++++++++++++++++++
>  9 files changed, 195 insertions(+)

Please don't include tests in this patch. Tests won't be committed until
they are useful, so send them once you have something useful in them and
as separated patch. For now, just strip them from the patch.

Also, you may consider sending public header (include/ual.h) as a
separated patch. And you don't need to include changes to generated
files (configure, configure.ac and include/Makefile.in).

Cheers,
Jacek


Reply via email to