On 10/10/2013 14:58, Jeff Latimer wrote:
---
dlls/wmvcore/Makefile.in | 2 +-
dlls/wmvcore/wmvcore_main.c | 100
+++++++++++++++++++++++++++++++++++++++++++-
include/wmsdkidl.idl | 11 ++---
3 files changed, 105 insertions(+), 8 deletions(-)
+typedef struct MetadataEditorImpl {
+ IWMMetadataEditor MetadataEditor_iface;
+ LONG ref;
+} MetadataEditorImpl;
+static inline MetadataEditorImpl *impl_from_MetadataEditor(IWMMetadataEditor
*iface)
Please follow naming convetions for interfaces.
+HRESULT WINAPI WMCreateEditor_close(IWMMetadataEditor *iface)
+{
+ FIXME("iface=%p\n", iface);
+ HeapFree(GetProcessHeap(), 0, iface);
+ return S_OK;
+}
+HRESULT WINAPI WMCreateEditor_flush(IWMMetadataEditor *iface)
+{
+ FIXME("iface=%p\n", iface);
+ HeapFree(GetProcessHeap(), 0, iface);
+ return S_OK;
+}
This looks totally wrong.
Also please keep implementation functions order and interface methods
order the same.