[ 
https://issues.apache.org/jira/browse/WINK-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728058#action_12728058
 ] 

Michael Elman commented on WINK-47:
-----------------------------------

Hi Mike,
I looked at your patch, it's a bit problematic. In the GreedyLinkedHashMap you 
override only get method with a special functionality. The problem with this 
solution that GreedyLinkedHashMap  may behave differently, when other Map 
methods are used. For example, what happens if keySet().contains() is invoked?
May be currently these methods are not used, but in the future any trivial 
change in code will cause a problem.
I prefer to think about a different solution, may be we'll need to change the 
MediaTypeMap implementation totally.

I promise to think about it, and everyone else is welcome to join :)

> honor media type wildcards
> --------------------------
>
>                 Key: WINK-47
>                 URL: https://issues.apache.org/jira/browse/WINK-47
>             Project: Wink
>          Issue Type: Bug
>          Components: Common
>    Affects Versions: 0.1
>            Reporter: Mike Rheinheimer
>             Fix For: 0.1
>
>         Attachments: patch.txt
>
>
> This issue probably needs discussion, as it may be a spec interpretation 
> issue.  Please reference JAX-RS javadoc for 
> javax.ws.rs.ext.Providers.getContextResolver here:
> http://jackson.codehaus.org/javadoc/jax-rs/1.0/javax/ws/rs/ext/Providers.html#getContextResolver(java.lang.Class,%20javax.ws.rs.core.MediaType)
> Currently, the implementation does not use the '*' character in a passed-in 
> media type as a wildcard.  Rather, it matches exactly by just allowing the 
> LinkedHashMap.get to it's object compare.  Attached is a patch with tests 
> that demonstrate the proposed function, and a fix that supports it.  All 
> existing and new tests in wink-common and wink-server passed for me with this 
> change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to