https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15842
--- Comment #12 from Tomasz Mon <deso...@gmail.com> ---
(In reply to Pascal Quantin from comment #11)
> Thanks for the feedback. So what would have been the frame with USBPcap
> 1.4.1.0?
The data packets would have different direction set (FDO->PDO instead of
PDO->FDO). This would result in USBPcap dissector to not pass this information
to subdissectors at all.
> Given that you just released USBPcap 1.5.0.0 that I'm gonna package in
> Wireshark 3.1.0.0 development builds, I might directly adapt the code to
> your new change. Should I assume that it is similar to usbmon now?
The USB payload as seen by the subdissectors will be the same as with usbmon.
This means that for SETUP packets from host to device, the tvb will include the
7 bytes of SETUP data (excluding bmRequestType) and the DATA OUT (if any). The
big advantage of such approach is the fact, that the subdissector doesn't have
to keep track of the information from SETUP packets that directly define the
meaning of DATA - as DATA OUT is always in the same tvb as SETUP. For the DATA
IN, it is the same as with usbmon.
It is possible to detect and reassemble old USBPcap traces (all versions before
1.5.0.0) to be handled like this, however I am not sure if it is really worth
the effort.
--
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
