URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d6f83a375d29217f4bf8e5e6b59672030fa4e602 Submitter: Guy Harris (g...@alum.mit.edu) Changed: branch: master-2.2 Repository: wireshark
Commits: d6f83a3 by Guy Harris (g...@alum.mit.edu): Handle quoted-pairs in quoted-strings correctly. Backslash, in a quoted-string, escapes quotes (and any other characters, although the only ones that *need* escaping are a double-quote and a backslash). This means that the value of a parameter isn't just the raw characters from the parameters string; for a quoted string, it needs to be un-escaped, and for a *non*-quoted string, it has to stop at the first non-token character (you can put comments in). So ws_find_media_type_parameter() must return an allocated string with the actual value. Get rid of index_of_char(); it doesn't do anything that strchr() does. Change-Id: I36328ea71c28fe6ac4918a8e73c281a25f6be844 Reviewed-on: https://code.wireshark.org/review/17251 Reviewed-by: Guy Harris <g...@alum.mit.edu> (cherry picked from commit 0b3a96222b39ea4df1fdc899a950c50ec56a1077) Reviewed-on: https://code.wireshark.org/review/17252 Actions performed: from d24bf49 2.2.0rc1 → 2.2.0rc2. adds d6f83a3 Handle quoted-pairs in quoted-strings correctly. Summary of changes: epan/dissectors/packet-isup.c | 17 +-- epan/dissectors/packet-multipart.c | 92 ++++++--------- epan/media_params.c | 222 +++++++++++++++++++++++++++--------- epan/media_params.h | 4 +- 4 files changed, 215 insertions(+), 120 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-requ...@wireshark.org?subject=unsubscribe