I was looking at the dissector I wrote recently, packet-exec.c, to remember how to handle conversations and I noticed a comment that isn't clear. It would throw someone off because it isn't how the dissector was finally written :). Please apply the attached patch to correct this.
Thanks, Steve
Index: epan/dissectors/packet-exec.c =================================================================== --- epan/dissectors/packet-exec.c (revision 18829) +++ epan/dissectors/packet-exec.c (working copy) @@ -69,11 +69,9 @@ #define EXEC_PASSWORD_LEN 16 #define EXEC_COMMAND_LEN 256 /* Longer depending on server operating system? */ -/* Initialize the structure that will be tied to each conversation - * This is used to display the username (and command?) in the INFO column of - * each packet as well as displaying hidden fields so filtering by these - * does not only show the first packet or two, but shows the entire - * conversation */ +/* Initialize the structure that will be tied to each conversation. + * This is used to display the username and/or command in the INFO column of + * each packet of the conversation. */ typedef enum { NONE = 0,
_______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev