Hi, the T.38 is PER dissector, i.e. it is not involved in changes in BER. BTW T.38 has been automatically generated since last week. I will make changes into asn2wrs activable with commandline option -X. @Anders, dou you have available any RNSAP traces? Regards, Tomas
________________________________ From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Anders Broman (AL/EAB) Sent: Monday, May 07, 2007 10:21 AM To: Developer support list for Wireshark Subject: SV: [Wireshark-dev] [Wireshark-commits] rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.c packet-ber.cpacket-ber.hpacket-camel.c ... Hi, Could you do the asn2wrs changes and send me the file then I could do some experiments and see how much work is involved? At least you have taken care of T38 then there is Kerberos and some gsm stuff so it might not be to difficult. Regards Anders ________________________________ Från: [EMAIL PROTECTED] genom Kukosa, Tomas Skickat: må 2007-05-07 09:42 Till: Developer support list for Wireshark Ämne: Re: [Wireshark-dev] [Wireshark-commits] rev21705:/trunk//trunk/plugins/asn1/:asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacket-acp133.cpacket-acse.cpacket-ansi_map.c packet-ber.cpacket-ber.hpacket-camel.c ... Hi, BTW when you are making such large changes do not you think about changing of packet-ber from "field oriented" to "type oriented"? I.e. replacing field_function() { type_function(hf_field); } sequence_structure[] = { {..., field_function}, } with code sequence_structure[] = { {&hf_field, ..., type_function}, } I did the same for PER last year and generated code is much shorter. Unfortunately it will be probaly very hard for BER as there are much BER code written by hands which can not be regenerated but has to be changed. regards, Tomas Mailcode: NdD2sKHg -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Anders Broman (AL/EAB) Sent: Monday, May 07, 2007 8:57 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 21705:/trunk//trunk/plugins/asn1/: asn1.hpacket-asn1.c/trunk/epan/dissectors/:packet-MAP_DialoguePDU.cpacke t-acp133.c packet-acse.cpacket-ansi_map.c packet-ber.cpacket-ber.h packet-camel.c ... Hi, I thought as much but there is still a lot of work to get the actx into all the BER dissecors. I'm taking it a step At the time. Regards Anders -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kukosa, Tomas Sent: den 7 maj 2007 07:58 To: wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 21705: /trunk//trunk/plugins/asn1/: asn1.h packet-asn1.c/trunk/epan/dissectors/: packet-MAP_DialoguePDU.cpacket-acp133.c packet-acse.c packet-ansi_map.c packet-ber.cpacket-ber.h packet-camel.c ... Hello Anders, I had not checked X.690 (BER) specification before I defined PER external structures in asn1_ctx_t. I expected BER uses encoding based on X.680 definition. I think we could merge most of PER and BER items in external structure. I will move PER items one layer upper and you can reuse them later in BER too. Regards, Tomas Mailcode: NdD2sKHg -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Monday, May 07, 2007 12:34 AM To: [EMAIL PROTECTED] Subject: [Wireshark-commits] rev 21705: /trunk/ /trunk/plugins/asn1/: asn1.h packet-asn1.c /trunk/epan/dissectors/: packet-MAP_DialoguePDU.c packet-acp133.c packet-acse.c packet-ansi_map.c packet-ber.c packet-ber.h packet-camel.c ... http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21705 User: etxrab Date: 2007/05/06 10:34 PM Log: Start introducing actx to ber functions. Directory: /trunk/plugins/asn1/ Changes Path Action +45 -0 asn1.h Modified +0 -1 packet-asn1.c Modified Directory: /trunk/epan/dissectors/ Changes Path Action +20 -20 packet-MAP_DialoguePDU.c Modified +56 -56 packet-acp133.c Modified +103 -103 packet-acse.c Modified +501 -501 packet-ansi_map.c Modified +13 -10 packet-ber.c Modified +2 -1 packet-ber.h Modified +434 -434 packet-camel.c Modified +8 -8 packet-cdt.c Modified +133 -133 packet-cmip.c Modified (68 files not shown) _______________________________________________ Wireshark-commits mailing list [EMAIL PROTECTED] http://www.wireshark.org/mailman/listinfo/wireshark-commits _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev _______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
_______________________________________________ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev
