On Fri, Jun 05, 2009 at 11:55:02PM +0200, didier wrote: > Le dimanche 31 mai 2009 à 11:56 +0200, Sake Blok a écrit : > > Hi Jaap (& list), > > > > As the "father" of the "copy as filter" functionality, I would vote for it > > to be present all the time in the packet details pane (where I use it > > most). > > Keeping track of all possible filters for the packet list pane seems like > > an > > overkill to me and could be made optional to save memory. Or it should be > > implemented in a way where it will dynamically be generated. For 1.2.0 I > > would suggest to just revert the implemented memory-consuming patch and > > disable the functionality in the packet-list. Then we can decide later to > > make it either optional of write code that dynamically generate the filter > > string on use (if that is at all possible). > > Anyone remember why it was changed from dynamically generate? > The SVN log msg doesn't make sense to me.
IIRC, the filter strings were not generated dynamically, they were generated while building the packet-list, resulting in having the filters for the last row to be the filters for all rows. But my memory might not be totally accurate ;-) Cheers, Sake ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe