Yes thats fine now. Martin On Mon, Aug 24, 2009 at 10:33 AM, Anders Broman <[email protected]>wrote:
> Please test with revision 29536. > > Anders > > ------------------------------ > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Martin Mathieson > *Sent:* den 24 augusti 2009 11:28 > *To:* [email protected] > *Subject:* Re: [Wireshark-dev] [Wireshark-commits] rev > 29535:/trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-tcp.c > > I'm getting this: > > packet-tcp.c: In function `dissect_tcp_payload': > packet-tcp.c:1551: warning: 'cleared_writable' might be used uninitialized > in this function > > Not sure what the default value should be... > > Martin > > On Mon, Aug 24, 2009 at 10:05 AM, <[email protected]> wrote: > >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=29535 >> >> User: etxrab >> Date: 2009/08/24 02:05 AM >> >> Log: >> From: : " Michael" >> >> packet-tcp marks a row as unwritable if there is more >> than 1 PDU in a packet to prevent overwriting of the >> protocol column. >> >> However this breaks the proto,colinfo tap which checks >> rows are writable or dies EVEN if it doesn't alter anything. >> >> Suggested patch attached to restore the initial value >> after all PDUs have been processed. >> >> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3675 >> >> Directory: /trunk/epan/dissectors/ >> Changes Path Action >> +10 -0 packet-tcp.c Modified >> >> >> ___________________________________________________________________________ >> Sent via: Wireshark-commits mailing list < >> [email protected]> >> Archives: http://www.wireshark.org/lists/wireshark-commits >> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits >> mailto:[email protected] >> ?subject=unsubscribe >> > > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
