Alexis La Goutte skrev 2011-01-21 17:32:
Hi,
I work on the file packet-ieee80211.c and I found that some header
field (tag_interpretation, cf_version ...) will not begin by hf_
There is a historic reason ?
Yes, the historic reason being that it slipped trough ;-)
There is a lot of stuff that should be fixed like misuse of tvb_get_ptr
hf naming etc.
Any effort to clean it up would be appreciated.
I think the hf variables should be prefixed with hf_ieee80211 to follow
the style of other
dissectors, unfortunately that's a bit long, hf_80211, hf_wifi?
if hf_ieee80211 is used throughout it's ease to shorten it later.
If you decide to clean it up a set of smaller patches is probably better
than a huge one.
Best regards
Anders
Because if I'm not mistaken, The checkhf.pl <http://checkhf.pl> file
only verifiedheader fields starting with hf_?
Regards,
___________________________________________________________________________
Sent via: Wireshark-dev mailing list<wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
