The Windows buildbots are complaining about this change and I don't know why. I don't have a Windows build to test on, but on Unix it doesn't compain (gcc) even if I add -Wsign-compare.
>From (only relevant portions shown): guint8 num_subrects, subrect_len; guint bytes_needed; bytes_needed = subrect_len * num_subrects; VNC_BYTES_NEEDED(bytes_needed); To: guint8 num_subrects, subrect_len; VNC_BYTES_NEEDED(subrect_len * num_subrects); Where VNC_BYTES_NEEDED is a macro: #define VNC_BYTES_NEEDED(a) \ if(a > (guint)tvb_length_remaining(tvb, *offset)) \ return a; The compiler warning: packet-vnc.c(1970) : warning C4018: '>' : signed/unsigned mismatch Any ideas? On Mon, Mar 28, 2011 at 02:21:27PM -0700, buildbot-no-re...@wireshark.org wrote: > The Buildbot has detected a new failure of Visual-Studio-Code-Analysis on > Wireshark (development). > Full details are available at: > > http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/289 > > Buildbot URL: http://buildbot.wireshark.org/trunk/ > > Buildslave for this Build: vs-code-analysis > > Build Reason: > Build Source Stamp: 36386 > Blamelist: sfisher > > BUILD FAILED: failed nmake all > > sincerely, > -The Buildbot > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe