On Jul 7, 2011, at 10:23 PM, Maynard, Chris wrote: >> -----Original Message----- >> From: [email protected] [mailto:wireshark-dev- >> [email protected]] On Behalf Of Michael Tüxen >> Sent: Thursday, July 07, 2011 4:08 PM >> To: Developer support list for Wireshark >> Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 37929: /trunk/gtk/ >> /trunk/gtk/: main_welcome.c >> >> On Jul 7, 2011, at 4:40 PM, Maynard, Chris wrote: >> >>>> -----Original Message----- >>>> From: [email protected] [mailto:wireshark- >>>> [email protected]] On Behalf Of [email protected] >>>> Sent: Thursday, July 07, 2011 9:57 AM >>>> To: [email protected] >>>> Subject: [Wireshark-commits] rev 37929: /trunk/gtk/ /trunk/gtk/: >>>> main_welcome.c >>>> >>>> >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=37929 >>>> >>>> User: tuexen >>>> Date: 2011/07/07 06:57 AM >>>> >>>> Log: >>>> Bring back interface icons. >>>> >>>> Obtained from Irene Ruengeler. >>>> >>>> Directory: /trunk/gtk/ >>>> Changes Path Action >>>> +23 -7 main_welcome.c Modified >>>> >>> >>> There's still one missing icon for the "Adapter for generic dialup >> and VPN capture". >> Any idea how to get this icon? We just use capture_get_if_icon(), so >> have no >> specific code any particular interface type. >> > > The icon comes from image/toolbar/modem_16.xpm, and you'll see it referenced > within the #if defined (_WIN32) block in > gtk/capture_if_dlg.c:capture_get_if_icon() as "modem_16_xpm". But in main_welcome.c we do just call capture_get_if_icon() to display the icon. So I have no idea why it is not displayed correctly. I just figured out that the argument of capture_get_if_icon() is declared to be not used, but it is. I committed a fix for that.
Is the icon displayed correctly in the Capture/Interfaces dialog, but not in the main welcome window? Best regards Michael > > CONFIDENTIALITY NOTICE: The contents of this email are confidential > and for the exclusive use of the intended recipient. If you receive this > email in error, please delete it from your system immediately and > notify us either by email, telephone or fax. You should not copy, > forward, or otherwise disclose the content of the email. > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe > ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
