Ok..sure..i will follow that approach and submit the dissectors for MPLS-TP Lockinstruct and loopback (RFC 6435 ) and MPLS-TP Fault Management (RFC 6427). Along with these, i was about coding PSC-State control also(RFC 6378) along with these. But, you have already done it i guess. So i will do rest 2 and submit the patches soon. No problem right??
On Sun, Mar 18, 2012 at 1:08 AM, <bugzilla-dae...@wireshark.org> wrote: > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6904 > > FF <francesco.fonde...@gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > CC| | > francesco.fonde...@gmail.co > | |m > > --- Comment #9 from FF <francesco.fonde...@gmail.com> 2012-03-17 12:38:04 > PDT --- > (In reply to comment #8) > > (In reply to comment #7) > > > Hi Anders, > > > Just a small doubt. Using "proto_add_item()" has any advantages ?? > > > I am just used to proto_tree_add_uint(). All i wanted was a tree by > name > > > 'MPLS-TP Lock Instruct message' which when opened gives the relevant > fields > > > under it. > > > Actually, for MEP TLV decoding also earlier, I had used the same > format. So, > > > was just trying to understand if it could make any difference?? > > > > No need local variable (li_version, refresh_timer...) > > > > Also please start your hf by hf_mpls_li... > > About change in bfd dissector, what it this type variable ? > > > > And if it is possible attach a simple patch with all change (from the 3 > files) > > Hi Alexis, all, > > please do not check this in as it is. I'm trying to move OAM stuff *out* > of > packet-mpls.c. As soon as possible I'd like to use a new table indexed by > channel_type and remove that ugly if-else-if-else in packet-mpls.c... > > Krishnamurthy Mayya please follow packet-mpls-pm.c or packet-mpls-y1711.c > or > packet-mpls-psc.c (bug #6966) approach. I believe it's easy, elegant > and simple. > > hope this make sense and helps > thank you > ciao > FF > > -- > Configure bugmail: > https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are watching all bug changes. > ___________________________________________________________________________ > Sent via: Wireshark-bugs mailing list <wireshark-b...@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-bugs > Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs > mailto:wireshark-bugs-requ...@wireshark.org > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
