On Tue, May 28, 2013 at 10:24:21AM -0400, [email protected] wrote:
> 
> expert_add_info_format_text()
> 
> Per some of the other discussions, this may not be the best name, but I would 
> like to eventually replace it with the existing expert_add_info_format name, 
> just with the expert info structure as an argument (an no severity, group 
> arguments), so that the "format"ing (printf) functionality is clearer.

Ah, thanks. I missed that part when looking at the changes to packet-arp.c
One question though: Why do we have a filled in text element (e.g. in 
packet-arp.c
we have "Duplicate IP address configured") in the ei[] array when the
call does require an actual formatting string (e.g. in packet-arp.c the arguemnt
to expert_add_info_format_text is "Duplicate IP address configured (%s)").

Thanks
    Jörg

-- 
Joerg Mayer                                           <[email protected]>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <[email protected]>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:[email protected]?subject=unsubscribe

Reply via email to