On Tue, Jan 21, 2014 at 2:40 AM, Guy Harris <g...@alum.mit.edu> wrote: > > On Jan 20, 2014, at 5:59 PM, Evan Huus <eapa...@gmail.com> wrote: > >> In which case is dumb search-and-replace of tvb_get_string with >> tvb_get_string_enc and ENC_ASCII an easy way to make (part of) the API >> transition? > > Did somebody say that had been done or suggest that it be done?
I thought it was kind of implied when you wrote "We should also probably audit all calls to tvb_get_string() and tvb_get_stringz() in dissectors and change them to tvb_get_string_enc() with the appropriate encoding." If tvb_get_string() behaves identically to tvb_get_string_enc(... ENC_ASCII) then there doesn't seem much point in having both. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
