Though I would note that if there are large swaths of an API that haven't been converted yet, that's an indicator that it's not as simple as a search-and-replace, so please don't just submit large changes like that, since it will likely break things in a subtle way (since the new/old APIs behave slightly differently so conversion needs to be done carefully).
Evan On Wed, Jun 18, 2014 at 12:35 AM, Dario Lombardo < dario.lombardo...@gmail.com> wrote: > I'm trying to taking care of some of the warnings from checkAPI. The > result is a set of commits. > What should I do now? > > 1) submit one push for every commit (eg. branch checkapi1, checkapi2, etc.) > > 2) submit one push with multiple commits (don't know if gerrit allows > it... I got an error when I tried to do so) > > 3) squash them into one commit (don't like it... the commits are > related to different APIs) > > 4) something else :) > > Thanks for your help. > Dario. > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
