On Mon, Sep 29, 2014 at 11:48 AM, Jeff Morriss <[email protected]> wrote: > On 09/29/14 08:58, Evan Huus wrote: >> >> Hmmm, the buildbot lua test suite is still failing even with this >> change, and it's no longer clear to me what the problem is. Hadriel, >> do you have any ideas off the top of your head? > > > It looks like it's because tshark is putting out higher-resolution time > stamps: > >> --- /tmp/testin.txt 2014-09-29 11:43:30.984826452 -0400 >> +++ /tmp/testout.txt 2014-09-29 11:43:30.985826484 -0400 >> @@ -1,1097 +1,1097 @@ >> 1 0.000000 0.0.0.0 -> 255.255.255.255 DHCP 314 DHCP Discover - >> Transaction ID 0x3d1d >> - 2 0.000000 192.168.0.1 -> 192.168.0.10 DHCP 342 DHCP Offer - >> Transaction ID 0x3d1d >> - 3 0.000070 0.0.0.0 -> 255.255.255.255 DHCP 314 DHCP Request - >> Transaction ID 0x3d1e >> - 4 0.000070 192.168.0.1 -> 192.168.0.10 DHCP 342 DHCP ACK - >> Transaction ID 0x3d1e >> + 2 0.000295 192.168.0.1 -> 192.168.0.10 DHCP 342 DHCP Offer - >> Transaction ID 0x3d1d >> + 3 0.070031 0.0.0.0 -> 255.255.255.255 DHCP 314 DHCP Request - >> Transaction ID 0x3d1e >> + 4 0.070345 192.168.0.1 -> 192.168.0.10 DHCP 342 DHCP ACK - >> Transaction ID 0x3d1e
Hmmm, interesting. Hadriel added [1] which fixes another chunk of the problem; if there are still issues then we'll have to see... [1] https://code.wireshark.org/review/#/c/4370/ > >>> 45fb377 by Evan Huus ([email protected]): >>> >>> Fix lua bindings to handle timestamp precision changes >>> >>> The recent wiretap changes broke the generation of init.lua among >>> other things, >>> though it did coincidentally fix one of the "yuck" comments in the >>> generator >>> regex. >>> >>> (Note that this is entirely untested, because out-of-tree init.lua >>> is and always >>> has been broken, but it should work) > > > Sure it does. Just not with cmake. :-) > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
