On Thu, Nov 6, 2014 at 1:09 PM, <mman...@netscape.net> wrote: > This and the subsequent commit (61676733b451bc8b3a83dee47df71c5ffe3f19dd) > that regenerated all of the DCE/RPC dissectors doesn't pass the "eye test" > to me. The newly generated code now has a lot of what appear to be > "duplicative" calls to ALIGN_TO_x_BYTES. The second call is effectively a > "no-op" because the bytes have already been "aligned", but does waste a > small amount of processing power. Looks like some additional logic in > NDR.pm may be necessary to prevent the duplication. Yes, i have see the same think, but no look the why...
May be ask to Mathieu (from Samba team) the creator of this patch ? > > Am I just missing something here? > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
