On Dec 14, 2014 3:04 PM, "Bill Meier" <wme...@newsguy.com> wrote: > > On 12/14/2014 2:22 PM, Stephen Fisher wrote: >> >> On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote: >> >>> That being said, the convention (certainly not enforced) seems to be >>> to use ENC_..._ENDIAN for fetching all integral types. >> >> >> Could this be related to when we made the change from using FALSE / TRUE >> to specify if its "big endian" in things like proto_tree_add_item() ? > > > > Good point ! > > fix-encoding-args.pl (used to do the change) just converted FALSE|0 to BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg". > > So, I stand corrected. > > Maybe what I should be doing is converting all the single-byte fetches to use ENC_NA. > > Thoughts ?
This makes sense to me. > Bill > > > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: http://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
