Thank you. It felt good to hit the button. What I'm hoping this change can do is open up better optimizations in proto.c I don't know enough to know how/what those optimizations could be, I just saw proto_tree_add_text as a roadblock. We still have a few other "text node" APIs if that is the holdup, but I think they would be more straightforward to replace (and far less in number than proto_tree_add_text ever was). -----Original Message----- From: Evan Huus <[email protected]> To: Michael Mann <[email protected]> Sent: Mon, Sep 21, 2015 10:05 am Subject: Re: [Wireshark-dev] The journey of a thousand miles...
I've +2ed it but I'll let you do the honours. I think we all owe you a beer now :) On Sun, Sep 20, 2015 at 10:48 PM, <[email protected]> wrote: > ... begins with a single step - Lao Tzu > > > The thousand mile journey has been completed as all proto_tree_add_text > calls within the Wireshark source have been converted to a "better" API. > Because they have been converted, I think proto_tree_add_text should be > removed from the Wireshark API. To me there has been enough notice given > and 2.0 looks like a good place to make the clean break (I was worried the > conversion wasn't going to be finished in time). Since the mailing list has > more eyes than Gerrit, I thought I'd send this notice in case there are > objections, which can be handled here or in the patch that removes the API > (https://code.wireshark.org/review/10594/). I am personally not in favor of > keeping it around just for third-party dissectors. > > convert_proto_tree_add_text.pl will remain and I will gladly answer any > questions people have (either email -dev or me directly). The initial > description of convert_proto_tree_add_text.pl can be found here: > https://www.wireshark.org/lists/wireshark-dev/201307/msg00073.html. There > have been more "features" added since, but the process to follow hasn't > changed - run it once to generate the list of proto_tree_add_text calls and > its "best guess" at what the conversion should be and then a second pass > over the tool's output to do search/replace of the proto_tree_add_text calls > with the data provided. > > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <[email protected]> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev > mailto:[email protected]?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <[email protected]> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:[email protected]?subject=unsubscribe
