On 4/24/18 7:16 AM, Richard Sharpe wrote:
> On Tue, Apr 24, 2018 at 3:28 AM, Anders Broman
> <anders.bro...@ericsson.com> wrote:
>>
>> From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf
>> Of Dario Lombardo
>> Sent: den 24 april 2018 12:06
>> To: Developer support list for Wireshark <wireshark-dev@wireshark.org>
>> Subject: [Wireshark-dev] SPEC files
>>
>>> Hi
>>
>>> What is the difference between packaging/rpm/wireshark.spec.in and
>>> packaging/rpm/SPECS/wireshark.spec.in? During my last patches I updated the
>>> former, but now I realized that there is also the latter.
>>
>> I think packaging/rpm/SPECS/wireshark.spec.in was the file used by autotools
>> and packaging/rpm/wireshark.spec.in is the ”new” file used by CMake the
>> former can probably be deleted now.
That's correct. Supporting Autotools and CMake from the same .spec.in seemed
like an exercise in frustration, especially given that we were planning on
dropping Autotools.
> Hmmm, that is weird. Normally, a SPEC file goes in the SPECS
> directory. Can we relocate them? (It is not mandatory, just a
> convention.)
>
> Do the tools generate the SPEC file in the correct place?
CMakeLists.txt creates packaging/rpm/{BUILD,RPMS,SOURCES,SPECS,SRPMS} in your
build directory and generates <build dir>/packaging/rpm/SPECS/wireshark.spec
from <source dir>/packaging/wireshark.spec.in. The other packaging/*
directories simply contain the files necessary to build their respective
packages. With that context in mind the dangling SPECS subdirectory seemed odd.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
