*"When linking with DBUILD_logray=ON, there won't be a WiresharkMainWindow, will there?"*
Both are built. Finally, as both logray and wireshark have the same parent class, I could move the implementation and just call the parent and all is now working. Le mar. 27 sept. 2022 à 16:38, chuck c <bubbas...@gmail.com> a écrit : > > https://gitlab.com/wireshark/wireshark/-/blob/19b04bf5ed906a1c03854595d424ad1e13f17df9/ui/qt/protocol_preferences_menu.cpp > WiresharkMainWindow* ptest; > ptest = new WiresharkMainWindow( > QApplication::topLevelAt(parentWidget()->mapToGlobal(QPoint())) ); > ptest->removeAdditionalToolbar(QString("test compil")); > delete ptest; > > When linking with DBUILD_logray=ON, there won't be a WiresharkMainWindow, > will there? > > It should be LograyMainWindow? > > https://gitlab.com/wireshark/wireshark/-/blob/master/ui/logray/logray_main_window.h > > > > On Tue, Sep 27, 2022 at 9:04 AM Eugène Adell <eugene.ad...@gmail.com> > wrote: > >> Yes Chuck, I did that multiple times, and just before pushing my latest >> code. >> >> Le mar. 27 sept. 2022 à 15:57, chuck c <bubbas...@gmail.com> a écrit : >> > >> > Since you have been working on it for a while, have you updated your >> master and rebased the MR branch? >> > >> > On Tue, Sep 27, 2022 at 7:06 AM Eugène Adell <eugene.ad...@gmail.com> >> wrote: >> >> >> >> Hi all, >> >> >> >> I've been working on MR !2445 for a while and almost finished this >> >> work, things were going rather well until DBUILD_logray=ON was added >> >> on the "Job Code Checks + Clang Warnings" job. It's still compiling >> >> and linking on my dev environment, but adding DBUILD_logray=ON is >> >> reproducing the same error there, which indeed is mentionning logray : >> >> >> >> /home/eugene/wireshark/ui/qt/protocol_preferences_menu.cpp:296: >> >> undefined reference to >> >> `WiresharkMainWindow::WiresharkMainWindow(QWidget*)' >> >> /usr/bin/ld: >> /home/eugene/wireshark/ui/qt/protocol_preferences_menu.cpp:303: >> >> undefined reference to `typeinfo for WiresharkMainWindow' >> >> /usr/bin/ld: >> /home/eugene/wireshark/ui/qt/protocol_preferences_menu.cpp:307: >> >> undefined reference to `WiresharkMainWindow::frameDataForRow(int) >> >> const' >> >> /usr/bin/ld: >> ui/logray/CMakeFiles/ui_logray.dir/__/qt/protocol_preferences_menu.cpp.o: >> >> in function >> `ProtocolPreferencesMenu::enumCustomTCPOverridePreferenceTriggered()': >> >> /home/eugene/wireshark/ui/qt/protocol_preferences_menu.cpp:417: >> >> undefined reference to `typeinfo for WiresharkMainWindow' >> >> /usr/bin/ld: >> /home/eugene/wireshark/ui/qt/protocol_preferences_menu.cpp:418: >> >> undefined reference to `WiresharkMainWindow::frameDataForRow(int) >> >> const' >> >> >> >> The failed pipeline is online : >> >> https://gitlab.com/eugene.adell/wireshark/-/pipelines/650129481 >> >> >> >> I haven't found anything in the mailing list archive, and searching in >> >> the pipelines logs with a keyword isn't enabled, as a consequence I am >> >> not able to find any support from similar previous experiences if so >> >> happened for anyone. >> >> >> >> Any idea why this compiling flag is breaking and what to do then ? >> >> >> >> best regards >> >> E.A. >> >> >> ___________________________________________________________________________ >> >> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> >> >> Archives: https://www.wireshark.org/lists/wireshark-dev >> >> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev >> >> mailto:wireshark-dev-requ...@wireshark.org >> ?subject=unsubscribe >> > >> > >> ___________________________________________________________________________ >> > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> >> > Archives: https://www.wireshark.org/lists/wireshark-dev >> > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev >> > mailto:wireshark-dev-requ...@wireshark.org >> ?subject=unsubscribe >> >> ___________________________________________________________________________ >> Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> >> Archives: https://www.wireshark.org/lists/wireshark-dev >> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev >> mailto:wireshark-dev-requ...@wireshark.org >> ?subject=unsubscribe >> > ___________________________________________________________________________ > Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> > Archives: https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org > ?subject=unsubscribe >
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev@wireshark.org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
