Hey Jordi, 2012/6/14 Jordi Rovira <[email protected]>: > I have some comments on the UpdatePasswordWidget class (github trunk), which > i reflect in the diff at the end of the mail. > > There are two minor changes i had to make: > - the first one is a null pointer check for the authModel_. It can be null > in some cases, like when called from "createUpdatePasswordView" with email > validation disabled (or something like this). This problem crashes the > server when the user clicks on the link provided in the email to change the > password.
Yes, that seems well observed. > - the second one freezes the server when the user fills the form to change > the password and clicks the "Ok" button. In the similar case where email > validation is disabled, the from didn't validate all the fields and it > wasn't doing anything on Ok pressed. I believe the proper fix is to mark the field invisible in the constructor, because then it always validates properly, and this was indeed not happening in all cases. I've applied these fixes in my tree. Regards, koen ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ witty-interest mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/witty-interest
