Bugs item #1446323, was opened at 2006-03-09 11:47 Message generated for change (Settings changed) made by barnson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1446323&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: light Group: v3.0 >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: tcassisi (tcassisi) Assigned to: Derek (derekc) Summary: Conflict using MSMs and Suppress Sequence Tables Initial Comment: After some digging through the source, it seems that the mergemod.dll used by WiX expects the relevant sequence tables (it doesn't say which ones specifically) to be present in the temporary MSI that WiX passes to it during the MergeEx call. I had Suppression of all these tables on, since I do not use Advt, Admin, or either of the UI modes. I was merging in the standard Microsoft v8 run times, specially ATL80 and MSVCRT80 DLLs, which are in 4 MSMs. Unfortunately, the merge.log is the only way to indicate what is happening, since WiX's error occurs later when it can't find the file table entries that were supposed to have been merged previously by the MergeEx call. Strangely enough, that call does not seem to return an error? The merge.log clearly shows one - something regarding can't find "Sequences table - Bad SQL". 1) WiX should correctly detect an error is occurred at that point and indicate it. Waiting until far later on gives an incomprehensible error about can't load row from file table. 2) It would be nice if WiX would ensure that there are empty entries in the temporary MSI for all the sequence tables prior to the MergeEx call. After the Merge, where the table suppression is currently done anyway for the MSMs, a Warning should be shown if the table about to be suppressed has entries in it. Either way, I do want to suppress the tables, since I know which ones I can do so in this case without any issue -- assuming WiX didn't remove the tables prior to doing the MergeEx call. :) Thanks. ---------------------------------------------------------------------- Comment By: Derek (derekc) Date: 2006-05-03 08:06 Message: Logged In: YES user_id=518766 Nice catch - this should now work. ---------------------------------------------------------------------- Comment By: tcassisi (tcassisi) Date: 2006-03-24 18:07 Message: Logged In: YES user_id=1453673 I put in a quick fix into the source to put back all the sequence table only if MSMs are referenced, since the MSM routine already removes the tables anyway if u've asked. Good enough for my purposes, but it would be nice to have this properly done in a future release. Search for "//TC:" to see the two changes (one before the routine and one in the routine). Suggest these are done properly (i.e. any empty tables after the Merge should be removed; not sure if they are right now.) See attachment. NOTE: The use of mergemod.dll should be discontinued and the MSMs should have their own decompile step and become full members of the WiX system. However, it may take some time to do there obviously other features that take priority of coding cleanups. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1446323&group_id=105970 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
