Bugs item #1790319, was opened at 2007-09-07 09:57 Message generated for change (Settings changed) made by robmen You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1790319&group_id=105970
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: pyro Group: v3.0 Status: Open Resolution: None Priority: 1 Private: No Submitted By: Heath Stewart (heaths) >Assigned to: Heath Stewart (heaths) Summary: Pyro uses English text for suminfo comments Initial Comment: Pyro takes the declared Patch/@DisplayName and prepends "This patch contains the logic and data required to install ". This is not localizable. We should either take DisplayName as-is (which doesn't uphold the recommended value for Comments), add a Comments attribute to Patch, or consider this as part of a larger effort to automatically localize some values based on the codepage or some other value. ---------------------------------------------------------------------- Comment By: Heath Stewart (heaths) Date: 2007-10-19 18:31 Message: Logged In: YES user_id=1335104 Originator: YES A proposed solution is to add a Package-like element to set summary information properties separately, and to also support the @SummaryCodepage. The Package element itself might work but certain attributes aren't useful, like Package/@AdminImage. This way, you not only avoid having to append English text but allow for a different code page for the summary information stream. Still, for backward compatibility Patch attributes should be set in the patch summary information stream where appropriate. ---------------------------------------------------------------------- Comment By: Heath Stewart (heaths) Date: 2007-10-18 11:17 Message: Logged In: YES user_id=1335104 Originator: YES Oops - meant code page 1252. ---------------------------------------------------------------------- Comment By: Heath Stewart (heaths) Date: 2007-09-07 11:16 Message: Logged In: YES user_id=1335104 Originator: YES Another idea is to add Patch/@SummaryComments - the naming of which is consistent with PatchInformation/@SummaryCodepage. This would create a row in _SummaryInformation in Compiler.cs. Patch.cs could then either *not* use the DisplayName at all (Patch/@SummaryComments or nothing at all), or to support existing authoring we could fallback to DisplayName and the hard-coded English text if Patch/@SummaryComments is missing. To note, the Comments summary property is not a required property so, other than for consistency, it really doesn't matter much what we do here so long as it isn't always in English. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=642714&aid=1790319&group_id=105970 ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
