Would it be possible for this version of wix.targets to be adopted by the team as the one that is currently distributed doesn't work with multiple wsx files?
Neil PS Thanks Michael Luke you saved me lots of time! -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Michael Luke Sent: 12 May 2006 09:22 To: [EMAIL PROTECTED]; 'Francis Kam'; 'Michael F. Collins, III' Cc: 'WiX-users' Subject: RE: [WiX-users] MSBuild Tasks Hi Rob, I made lots of changes to the MSBuild wix.targets a while back to fix a few bugs, but got stymied by the (to me) ridiculous requirement of downloading a pdf, printing it out, filling it in in ink and posting it thousands of miles to Seattle, just so I could submit the changes to the project. I've worked on many open source projects, and this is the first one I've seen with such a requirement. Anyway, I'm not going to sign and post the contributor's agreement, because it's waaaaay too much hassle. Attached is the modified .targets file, and I relinquish all rights blah di blah for my changes. This .targets file fixes the following issues: - Made incremental builds work correctly (a task will only run if source files have changed) - Allowed multiple wxs files to be used in one msi - Added BeforeXXX and AfterXXX targets for each action to allow for build custom tasks. This is consistent with Microsoft's existing Team Build targets. - Moved the path to $(MSBuildExtensionsPath)\Windows Installer XML\Wix.targets (c:\program files\MsBuild\Windows Installer XML) to be consistent with MsBuild standards. The wixtasks.dll and wix.targets files should both be installed to this location. To use it, you simply create an MsBuild project file (such as the MsBuild.proj attached) and pass that to MsBuild. Michael Luke [EMAIL PROTECTED] wrote: > Quick piece of information. The MSBuild tasks were written by > somebody quickly and just handed to us. There hasn't been any more > maintenance on the code since then. At this point in time, I expect > you know more about how MSBuild works than anyone on the core WiX > development team. Your bugs and suggestions would be much > appreciated. > > > > ________________________________ > > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Francis > Kam Sent: Thursday, May 11, 2006 3:52 PM > To: Michael F. Collins, III > Cc: WiX-users > Subject: Re: [WiX-users] MSBuild Tasks > > > > Thanks for the reply. I've modified the wix.targets for multiple > output support and it seems to be working fine. I'm rather > inexperienced with MSBuild, so maybe I'm just missing something, but > isn't the only way to get an array of strings to use item groups > instead of properties? You really should be able to define more than > one preprocessor variable from the commandline and it seems to me the > only way is to change DefineConstants to an item group. I've done > this with minimal negative side-effects so far. Anyhow, it's good to > see I'm not crazy, and this is a path that others have considered and > followed before me. > > > > Just in case someone else is interested, what I ended up doing for > multiple output support was changing CompileObjOutput to an ItemGroup, > and then including: > > > @(Compile->'$(IntermediateOutputPath)%(filename)$(IntermediateExt)') > > The Compile target's output of course then becomes: > > @(CompileObjOutput) > > Then I changed OutputFile in the call to Candle in that Compile target > to: > > $(IntermediateOutputPath) > > Instances of $(CompileObjOutput) in the other targets were changed to > @(CompileObjOutput) as well. > > > > -Francis
MsBuild.proj
Description: MsBuild.proj
wix.targets
Description: wix.targets
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
