George, On initial installations Windows Installer seems to be a little more lenient in passing public properties that are not secure while being more stringent in maintenance operations (such as repairs). There are rules (search MSDN for secure properties in the windows installer section) but the upshot is if you will use either the commandline or the UI to set the values (especially in maintenance mode transactions) you need to "secure" the properties. If you use the remember pattern in the execute sequence you don't need to secure the properties to reuse the previously used ones (although passwords and the remember pattern don't work well together). Hope this helps. Blair Murri > From: r...@robmensching.com > Date: Fri, 14 Jun 2013 21:25:30 -0700 > To: wix-users@lists.sourceforge.net > Subject: Re: [WiX-users] Patching error > > Did you "remember" those properties? Remember, patching is really just a > repair. If repairing (without providing any extra parameters) fails > patching will too. > > > On Fri, Jun 14, 2013 at 4:42 PM, George Fleming <gef...@microsoft.com>wrote: > > > If that's the case, I don't understand how normal installs work, but only > > patching fails. I have no problem if I type: > > > > Msiexec /i My.msi /L*v log SERVICEACCOUNT="xxx" SERVICEPASSWORD="yyy" > > > > i.e. use /i instead of /p. Why does "secure" matter in patching, but not > > in normal install? > > > > -----Original Message----- > > From: Phil Wilson [mailto:phil.wil...@mvps.org] > > Sent: Friday, June 14, 2013 3:25 PM > > To: 'General discussion for Windows Installer XML toolset.' > > Subject: Re: [WiX-users] Patching error > > > > It's the "ignoring" part that is the issue, that's David's point. > > Properties will not be propagated from the UI sequence (and command lines) > > unless they are marked secure. Internally that's here in the MSI file: > > > > > > http://msdn.microsoft.com/en-us/library/windows/desktop/aa371571(v=vs.85).as > > px > > > > So they need to be secure or they are gone when your code runs on the > > server side. > > > > Phil > > > > -----Original Message----- > > From: George Fleming [mailto:gef...@microsoft.com] > > Sent: Friday, June 14, 2013 1:17 PM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] Patching error > > > > I installed the patch using command line... > > > > Msiexec /p My.msi /L*v log SERVICEACCOUNT="xxx" SERVICEPASSWORD="yyy" > > > > I know parameters don't persist, but shouldn't they be defined if you > > explicitly supply them via command line parameters? > > > > -----Original Message----- > > From: David Watson [mailto:dwat...@sdl.com] > > Sent: Friday, June 14, 2013 10:00 AM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] Patching error > > > > If you install your program on a test machine then run a repair from ARP > > or the command line does it fail with the same error? > > > > If you have not persisted these settings then they will be undefined or > > set to whatever default you specified during a repair or patch, unless you > > only install patches from the command line and re-specify the parameters. > > Error > > 0x80070103 is "No more data is available." which suggests that the > > properties are unset. > > > > The 'ignoring' message is a warning when properties are not secure (i.e. > > you did not set the @secure attribute on the property definition) that > > means it does not get passed between the execute and ui sequences. It's > > usually a good idea to do this for public properties. > > > > Dave > > > > -----Original Message----- > > From: George Fleming [mailto:gef...@microsoft.com] > > Sent: 14 June 2013 17:25 > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] Patching error > > > > What do you mean by "repairs correctly"? The patch log shows errors, so I > > assumed that means it didn't repair correctly? > > > > I don't store the values of SERVICEACCOUNT or SERVICEPASSWORD, but they > > are provided via command-line parameters. However, I just noticed from the > > log these lines: > > > > Ignoring disallowed property SERVICEACCOUNT Ignoring disallowed property > > SERVICEPASSWORD > > > > -----Original Message----- > > From: David Watson [mailto:dwat...@sdl.com] > > Sent: Friday, June 14, 2013 1:50 AM > > To: General discussion for Windows Installer XML toolset. > > Subject: Re: [WiX-users] Patching error > > > > A patch application is just a repair with all relevant patch > > transformations applied to the msi. > > Check if your MSI repairs correctly. > > Do you persist SERVICEACCOUNT and SERVICEPASSWORD? > > > > > > -----Original Message----- > > From: George Fleming [mailto:gef...@microsoft.com] > > Sent: 13 June 2013 22:54 > > To: WiX-users@lists.sourceforge.net > > Subject: [WiX-users] Patching error > > > > I following online instructions and created a patch (msp file). There > > were no errors during the creation. When I tried to verify the patch by > > applying it, I got following error: > > > > MSI (s) (C0:F0) [13:36:29:463]: Executing op: > > ActionStart(Name=CreateUser,,) MSI (s) (C0:F0) [13:36:29:463]: Executing op: > > > > CustomActionSchedule(Action=CreateUser,ActionType=11265,Source=BinaryData,Ta > > r > > get=**********,CustomActionData=**********) > > MSI (s) (C0:88) [13:36:29:463]: Invoking remote custom action. DLL: > > C:\Windows\Installer\MSIA410.tmp, Entrypoint: CreateUser MSI (s) (C0:9C) > > [13:36:29:463]: Generating random cookie. > > MSI (s) (C0:9C) [13:36:29:463]: Created Custom Action Server with PID 3760 > > (0xEB0). > > MSI (s) (C0:A8) [13:36:29:495]: Running as a service. > > MSI (s) (C0:FC) [13:36:29:495]: Hello, I'm your 32bit Elevated custom > > action server. > > CreateUser: Error 0x80070103: failed to read attributes from custom > > action data CustomAction CreateUser returned actual error code 1603 (note > > this may not be 100% accurate if translation happened inside sandbox) > > Action ended > > 13:36:29: InstallFinalize. Return value 3. > > > > My code that has "CreateUser" in it is: > > > > <Component Id='********' Win64="$(var.Win64)" > > Guid='{*****************************}' > > > <util:User Id='*******' Name='[SERVICEACCOUNT]' > > Password='[SERVICEPASSWORD]' CreateUser='no' LogonAsService='yes'/> > > <File Id="***********" Name="**********" KeyPath="yes" > > Source="*************" /> > > <ServiceInstall Id='*********' > > Name='**********' > > DisplayName='***********' > > Type='ownProcess' > > Start='auto' > > ErrorControl='normal' > > Description='**************' > > Account='[SERVICEACCOUNT]' > > Password='[SERVICEPASSWORD]' > > Vital='yes'> > > <util:ServiceConfig FirstFailureActionType='restart' > > SecondFailureActionType='restart' ThirdFailureActionType='none' > > RestartServiceDelayInSeconds='10' > > ResetPeriodInDays='1'/> > > </ServiceInstall> > > <ServiceControl Id="StartService" Stop="both" Remove="uninstall" > > Name="**************" Wait="yes" /> > > </Component> > > > > I am a bit at loss as to how to fix this problem. I have heard that when > > patching, custom actions lose their parameters. Is this true? If > > util:user is internally implemented as a custom action, how do I get around > > this? > > > > Thanks, > > > > George > > > > ---------------------------------------------------------------------------- > > - > > - > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > SDL PLC confidential, all rights reserved. > > If you are not the intended recipient of this mail SDL requests and > > requires that you delete it without acting upon or copying any of its > > contents, and we further request that you advise us. > > SDL PLC is a public limited company registered in England and Wales. > > Registered number: 02675207. > > Registered address: Globe House, Clivemont Road, Maidenhead, Berkshire SL6 > > 7DY, UK. > > > > > > > > ---------------------------------------------------------------------------- > > - > > - > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > > > > > ---------------------------------------------------------------------------- > > - > > - > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > ---------------------------------------------------------------------------- > > -- > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > > > > > ---------------------------------------------------------------------------- > > -- > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > > > ------------------------------------------------------------------------------ > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > > > > > > > > ------------------------------------------------------------------------------ > > This SF.net email is sponsored by Windows: > > > > Build for Windows Store. > > > > http://p.sf.net/sfu/windows-dev2dev > > _______________________________________________ > > WiX-users mailing list > > WiX-users@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wix-users > > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows:
Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
