You want me to make the change for 3.8 or your going to make the change? I can send you my code for the BA if you want :)
-----Original Message----- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: August-28-13 12:34 PM To: afor...@cmu.edu; General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] Add text to final window in burn bootstrapper/installer Yes that was for Steven: he's made exactly the same changes I was hoping to get around to making, and I'd like to see them get into WiX 3.8 if possible. -- Bruce Sent from my iPhone On 28 Aug 2013, at 16:52, "Alain Forget" <afor...@cmu.edu> wrote: > I hope that's directed at Steven, because I don't know what that means (and I > have yet to figure out where and how to modify .wxl files). > > Alain > > -----Original Message----- > From: Bruce Cran [mailto:br...@cran.org.uk] > Sent: Wednesday, August 28, 2013 11:39 AM > To: General discussion for Windows Installer XML toolset. > Subject: Re: [WiX-users] Add text to final window in burn > bootstrapper/installer > > Could you sent a pull request to integrate this change upstream please? > > -- > Bruce Cran > > Sent from my iPhone > > On 28 Aug 2013, at 14:28, Steven Ogilvie <steven.ogil...@titus.com> wrote: > >> Yes exactly >> >> BA is using the same property for Setup/Uninstall for the >> success/failure string >> >> I fixed this by changing the code in BA and adding a few extra string >> properties in the theme wxl file <String Id="SuccessHeader">Setup >> Successful</String> <String Id="SuccessSetupHeader">Setup >> Successful</String> <String Id="SuccessUninstallHeader">Uninstall >> Successful</String> <String Id="FailureHeader">Setup Failed</String> >> <String Id="FailureSetupHeader">Setup Failed</String> <String >> Id="FailureUninstallHeader">Uninstall Failed</String> >> >> BA: >> >> { WIXSTDBA_CONTROL_SUCCESS_HEADER, L"SuccessHeader" }, >> { WIXSTDBA_CONTROL_SUCCESS_SETUP_HEADER, L"SuccessSetupHeader" }, >> { WIXSTDBA_CONTROL_SUCCESS_UNINSTALL_HEADER, >> L"SuccessUninstallHeader" }, >> >> { WIXSTDBA_CONTROL_FAILURE_HEADER, L"FailureHeader" }, >> { WIXSTDBA_CONTROL_FAILURE_SETUP_HEADER, L"FailureSetupHeader" }, >> { WIXSTDBA_CONTROL_FAILURE_UNINSTALL_HEADER, >> L"FailureUninstallHeader" }, >> >> The in OnChangeState is where I set the correct string >> >> >> -----Original Message----- >> From: Bruce Cran [mailto:br...@cran.org.uk] >> Sent: August-28-13 2:26 AM >> To: General discussion for Windows Installer XML toolset. >> Subject: Re: [WiX-users] Add text to final window in burn >> bootstrapper/installer >> >> On 28/08/2013 06:07, Blair Murri wrote: >>> As I understand it, page "Success" will be shown whenever the result of >>> bundle application is successful but not when a failure occurs (when >>> instead the "Failure" page will be shown). So, successful install, >>> successful removal, successful modification, etc. >>> If you can set bundle properties you can use that property's value as your >>> text, maybe... >> >> There was a discussion on wix-devs about this a few months ago: the WixStdBA >> bootstrapper needs changed to allow better text on the 'success' pages. In >> particular, people have complained to me about the fact that when uninstall >> completes it reports "Setup Success". >> >> -- >> Bruce Cran >> >> --------------------------------------------------------------------- >> --------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >> 2012, more! >> Discover the easy way to master current and previous Microsoft technologies >> and advance your career. Get an incredible 1,500+ hours of step-by-step >> tutorial videos with LearnDevNow. Subscribe today and save! >> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >> clktrk _______________________________________________ >> WiX-users mailing list >> WiX-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wix-users >> >> --------------------------------------------------------------------- >> --------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL >> 2012, more! >> Discover the easy way to master current and previous Microsoft >> technologies and advance your career. Get an incredible 1,500+ hours >> of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! >> http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg. >> clktrk _______________________________________________ >> WiX-users mailing list >> WiX-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wix-users > > ---------------------------------------------------------------------- > -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and previous Microsoft > technologies and advance your career. Get an incredible 1,500+ hours > of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > lktrk _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > > ---------------------------------------------------------------------- > -------- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL > 2012, more! > Discover the easy way to master current and previous Microsoft > technologies and advance your career. Get an incredible 1,500+ hours > of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! > http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.c > lktrk _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
