Daniel Isenmann wrote: > I really appreciate your work in the GIT repository and your handling > of patches from the others.
Thanks. I try to be very careful when applying patches. So one rule I have for the patches I apply is that they must do one thing and one thing only, and have a well explained reason for why one should do that in the first place, in plain English. It made my life much more difficult because many patches were scattered around, usually with the log "applied patch foo" or not even that, just a plain .diff file. I also did that to learn about the code being patched, but I really think that having a well written history of the changes is an important part of having a great code for the future. And that is what I wanted for myself in the beginning :-) > As I said it before, I would really like to see that all the work from > the different repositories would be managed in one to provide the best > WindowMaker experience and to (re-)activate the official WindowMaker > development. I am sure I missed some patches from other sources, but due to my rule of understanding the reason of why the patch is needed in plain English, that is a time consuming task for me. So if my repo becomes more popular and people notice some patch from somewhere else which is not there, I would very much appreciate if they could provide the sensible commit log I look for (so that I can check myself what the bug is and test it before applying). If that comes in a 'git format-patch' compliant way, so that I can simply apply in zero seconds with 'git am', that will be the paradise! -- To unsubscribe, send mail to [email protected].
