On Mon 14.Sep'09 at 15:03:37 +0100, Iain Patterson wrote: > As promised here are various patches against git next. The content is > the same as I've posted before modulo a few tweaks.
Thanks Iain! I pushed them to 'next', where it will rest for a few days. If people have some comments I would like to know, as I won't test the xinerama bits of it. I have just a small (and a bit irrelevant) comment about cleanliness to make. > + xx = rect.pos.x + (scr->xine_info.screens[head].size.width - > (w+4))/2; > + yy = rect.pos.y + (scr->xine_info.screens[head].size.height - > (h+4))/2; You added this with no spaces around the "+" > - xx = rect.pos.x + (scr->xine_info.screens[head].size.width - > (w+4))/2; > - yy = rect.pos.y + (scr->xine_info.screens[head].size.height - > (h+4))/2; > + xx = rect.pos.x + (scr->xine_info.screens[head].size.width - (w > + 4)) / 2; > + yy = rect.pos.y + (scr->xine_info.screens[head].size.height - > (h + 4)) / 2; And then you "polluted" your next patch by adding the spaces where they should have been in the first place. > - xx = (scr->scr_width - (w+4))/2; > - yy = (scr->scr_height - (h+4))/2; > + xx = (scr->scr_width - (w + 4)) / 2; > + yy = (scr->scr_height - (h + 4)) / 2; and here too. They made your patch about the padding look like it was doing more than described at first sight, until I noticed the trivial space issue... If you had noticed this after writing your first patch, you could have avoided it by doing a middle step patch fixing the spaces and then using git rebase -i to squash the patch into the previous one, so that the next one would be cleaner and the previous one too. But that is just me being boring now, and you can ignore me :-) -- To unsubscribe, send mail to [email protected].
