Ie, why not move the assignment of 'src' to after the test?
I thought about this, but I checked the 3 different calls to
updateWorkspaceMenu (all in winmenu.c). They must all call
updateWorkspaceMenu with non-NULL pointers, so if we have a NULL 'menu'
pointer then we obviously have a major problem and it is probably better
to crash here than to silently return and fail a little latter.
This test is probably a remnant of earlier code.
If you really want to have a test, this should be assert(menu) (but it
is useless here).
Nicolas
--
To unsubscribe, send mail to [email protected].
